Chromium support for webkitAnimationTime property

Chromium support for webkitAnimationTime property

These are the chrome changes needed for https://bugs.webkit.org/show_bug.cgi?id=51952.

BUG=64848
TEST=layout tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70626

[jamesr, 2011-01-06 02:34:44]

This patch adds one call to a new function that
https://bugs.webkit.org/show_bug.cgi?id=51952 will add to WebWidget and adds an
(empty) implementation of that function to PepperWidget, which implements
WebWidget.  Assuming this looks good what I'll do to land this mess is:

1.) Land the change to render_widget_fullscreen_pepper.cc in chromium by itself
2.) Land the WebKit patch to add the new function to WebWidget
3.) Wait for a WebKit roll
4.) Land the change to render_widget.cc to call the newly added function.

[darin (slow to review), 2011-01-06 05:52:29]

LGTM

http://codereview.chromium.org/5962018/diff/1/chrome/renderer/render_widget.cc
File chrome/renderer/render_widget.cc (right):

http://codereview.chromium.org/5962018/diff/1/chrome/renderer/render_widget.c...
chrome/renderer/render_widget.cc:569: webwidget_->clearCurrentAnimationTime();
what about other places where we call WebWidget::paint(), like
PaintViewIntoCanvas() in render_view.cc?

it is unfortunate that we need to expose such a low-level detail to the embedder
here.  <half-baked> it would be neat if we had beginPaint() and endPaint()
functions wrapping the set of paint() calls.  then we could hide clearing of the
current animation time inside endPaint(), and maybe layout() and animate() steps
could be hidden in beginPaint(). </half-baked>

[jamesr, 2011-01-06 18:41:30]

> it is unfortunate that we need to expose such a low-level detail to the
embedder
> here.  <half-baked> it would be neat if we had beginPaint() and endPaint()
> functions wrapping the set of paint() calls.  then we could hide clearing of
the
> current animation time inside endPaint(), and maybe layout() and animate()
steps
> could be hidden in beginPaint(). </half-baked>

Yeah - it's really tedious currently to have to modify
render_widget_fullscreen_pepper.cc, WebViewImpl.h/cpp, and
WebMenuPopupImpl.h/cpp every time WebWidget changes.

[jamesr, 2011-01-06 18:52:04]

One wrinkle is that test_shell and DRT call layout() independently of rendering,
so we can't totally hide that call.

[darin (slow to review), 2011-01-06 22:30:14]

I see.  Anyways, this'll all get fixed once we move 2D rendering to an
output-style device.

-Darin


On Thu, Jan 6, 2011 at 10:52 AM, <jamesr@chromium.org> wrote:

> One wrinkle is that test_shell and DRT call layout() independently of
> rendering,
> so we can't totally hide that call.
>
>
> http://codereview.chromium.org/5962018/
>