Issue 596117: Object.getOwnPropertyNames should return string names for indexed properties....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 596117: Object.getOwnPropertyNames should return string names for indexed properties.... (Closed)

Created:
10 years, 10 months ago by pfeldman

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse, yurys

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Object.getOwnPropertyNames should return string names for indexed properties.

Patch Set 1 #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	src/v8natives.js	View		2 chunks	+5 lines, -2 lines	0 comments	Download
	M	test/mjsunit/object-get-own-property-names.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM This was not caught by any ES5 conformance tests?

10 years, 10 months ago (2010-02-16 08:56:34 UTC) #2

yurys

10 years, 10 months ago (2010-02-16 10:09:04 UTC) #3

On 2010/02/16 08:56:34, Søren Gjesse wrote:
> LGTM
> 
> This was not caught by any ES5 conformance tests?

Sending        src/v8natives.js
Sending        test/mjsunit/object-get-own-property-names.js
Transmitting file data ..
Committed revision 3866.

Expand Messages | Collapse Messages