Issue 596116: Elaborating test for Array.shift a bit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 596116: Elaborating test for Array.shift a bit. (Closed)

Created:
10 years, 10 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Elaborating test for Array.shift a bit. Committed: http://code.google.com/p/v8/source/detail?r=3855

Patch Set 2 : putting deletions into assertTrue #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -4 lines)			Patch
	M	test/mjsunit/array-shift.js	View	1	1 chunk	+29 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM, thanks! http://codereview.chromium.org/596116/diff/1/2 File test/mjsunit/array-shift.js (right): http://codereview.chromium.org/596116/diff/1/2#newcode68 test/mjsunit/array-shift.js:68: delete Array.prototype[3]; Why do you have these ...

10 years, 10 months ago (2010-02-15 11:34:02 UTC) #2

antonm

10 years, 10 months ago (2010-02-15 12:01:23 UTC) #3

Thanks a lot for review, Mads, committing.

http://codereview.chromium.org/596116/diff/1/2
File test/mjsunit/array-shift.js (right):

http://codereview.chromium.org/596116/diff/1/2#newcode68
test/mjsunit/array-shift.js:68: delete Array.prototype[3];
On 2010/02/15 11:34:02, Mads Ager wrote:
> Why do you have these deletes here?  If you want them, you should test if they
> return true or false.

I don't want to pollute Array.prototype object in case we add more tests. 
Wrapped into assertTrue's.

Expand Messages | Collapse Messages

Issue 596116: Elaborating test for Array.shift a bit. (Closed)

Description

Patch Set 1 #

Patch Set 2 : putting deletions into assertTrue #

Messages