Rework build_autotest.sh

Two major changes here:

1. work with the new portage build system. Yes, cross compiling works.

2. work with new upstream changes to build a single or a subset of site test which specified from command line.

I will update the how-to document after all code checked in.

Please also refer to change from 582012 which had been included here and 582012 will be abandoned after this CL checked in.

[seano, 2010-02-15 07:42:43]

LGTM

http://codereview.chromium.org/596110/diff/1002/5
File src/scripts/build_autotest.sh (right):

http://codereview.chromium.org/596110/diff/1002/5#newcode22
src/scripts/build_autotest.sh:22: DEFINE_string build "${DEFAULT_TESTS_LIST}" \
nit: Separate the constant from the FLAGS with a blank line? You could just use
the flag default as the constant here, really.

http://codereview.chromium.org/596110/diff/1002/5#newcode23
src/scripts/build_autotest.sh:23: "a comma seperated list of autotest client
tests to be prebuilt."
Add a shortcut flag, 'b'

http://codereview.chromium.org/596110/diff/1002/5#newcode24
src/scripts/build_autotest.sh:24: DEFINE_boolean prompt $FLAGS_TRUE "Prompt user
when building all tests"
nit: I like to put the FLAGS in alphabetic order.

http://codereview.chromium.org/596110/diff/1002/5#newcode68
src/scripts/build_autotest.sh:68: echo "You could use --test_list to specify
tests you like to pre-compile."
minus
 "you could "

http://codereview.chromium.org/596110/diff/1002/5#newcode68
src/scripts/build_autotest.sh:68: echo "You could use --test_list to specify
tests you like to pre-compile."
I think you mean --build

[ericli, 2010-02-15 19:56:42]

Pushed. Please refer to my final comments.

http://codereview.chromium.org/596110/diff/1002/5
File src/scripts/build_autotest.sh (right):

http://codereview.chromium.org/596110/diff/1002/5#newcode22
src/scripts/build_autotest.sh:22: DEFINE_string build "${DEFAULT_TESTS_LIST}" \
EFAULT_TESTS_LIST is also reused elsewhere. So I think its better to keep it as
a VAR.

empty line added.

On 2010/02/15 07:42:44, seano wrote:
> nit: Separate the constant from the FLAGS with a blank line? You could just
use
> the flag default as the constant here, really.

Done.

http://codereview.chromium.org/596110/diff/1002/5#newcode23
src/scripts/build_autotest.sh:23: "a comma seperated list of autotest client
tests to be prebuilt."
On 2010/02/15 07:42:44, seano wrote:
> Add a shortcut flag, 'b'

Done.

But I should remind you there is also another FLAG starts with b (board) and I
wish FLAG_board could be defined inside common.sh.

http://codereview.chromium.org/596110/diff/1002/5#newcode24
src/scripts/build_autotest.sh:24: DEFINE_boolean prompt $FLAGS_TRUE "Prompt user
when building all tests"
On 2010/02/15 07:42:44, seano wrote:
> nit: I like to put the FLAGS in alphabetic order.

Done.

http://codereview.chromium.org/596110/diff/1002/5#newcode68
src/scripts/build_autotest.sh:68: echo "You could use --test_list to specify
tests you like to pre-compile."
Good catch.

On 2010/02/15 07:42:44, seano wrote:
> I think you mean --build
> 

Done.