Bookmark Manager Drag and Drop backend....

chrome/browser/extensions/extension_dom_ui.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_dom_ui.h"
 
 #include "base/string_util.h"
 #include "chrome/browser/browser.h"
 #include "chrome/browser/browser_list.h"
+#include "chrome/browser/extensions/extension_bookmark_manager_api.h"
 #include "chrome/browser/extensions/extensions_service.h"
 #include "chrome/browser/pref_service.h"
 #include "chrome/browser/profile.h"
 #include "chrome/browser/renderer_host/render_widget_host_view.h"
 #include "chrome/browser/tab_contents/tab_contents.h"
 #include "chrome/common/bindings_policy.h"
+#include "chrome/common/chrome_switches.h"
 #include "chrome/common/url_constants.h"
 
 namespace {
 const wchar_t kExtensionURLOverrides[] = L"extensions.chrome_url_overrides";
 }
 
 ExtensionDOMUI::ExtensionDOMUI(TabContents* tab_contents)
     : DOMUI(tab_contents) {
   // TODO(aa): It would be cool to show the extension's icon in here.
   hide_favicon_ = true;
@@ skipping 15 matching lines @@
 void ExtensionDOMUI::ResetExtensionFunctionDispatcher(
     RenderViewHost* render_view_host) {
   // Use the NavigationController to get the URL rather than the TabContents
   // since this is the real underlying URL (see HandleChromeURLOverride).
   NavigationController& controller = tab_contents()->controller();
   const GURL& url = controller.GetActiveEntry()->url();
   extension_function_dispatcher_.reset(
       new ExtensionFunctionDispatcher(render_view_host, this, url));
 }
 
+void ExtensionDOMUI::ResetExtensionBookmarkManagerEventRouter() {
+  // TODO(arv): Move to ExtensionHost?

[Erik does not do reviews, 2010/02/19 23:47:17]

ExtensionsService - but maybe I misunderstood what was going on here.  Does each
DOMUI need its own router?  And is it specific to tab contents?  I was used to
the other event routers which were more global.  If that's the case, then I
think it's OK to keep it here.

[arv (Not doing code reviews), 2010/02/20 00:04:31]

Yes, each ExtensionDOMUI tab contents needs its own router. I was thinking that
maybe the extension service could be used to only dispatch to the view that the
user was dragging over.

After looking at ExtensionsService I think the current solution is clearer.

+  if (CommandLine::ForCurrentProcess()->HasSwitch(
+      switches::kEnableExperimentalExtensionApis)) {
+    extension_bookmark_manager_event_router_.reset(
+        new ExtensionBookmarkManagerEventRouter(GetProfile(), tab_contents()));
+  }
+}
+
 void ExtensionDOMUI::RenderViewCreated(RenderViewHost* render_view_host) {
   ResetExtensionFunctionDispatcher(render_view_host);
+  ResetExtensionBookmarkManagerEventRouter();
 }
 
 void ExtensionDOMUI::RenderViewReused(RenderViewHost* render_view_host) {
   ResetExtensionFunctionDispatcher(render_view_host);
+  ResetExtensionBookmarkManagerEventRouter();
 }
 
 void ExtensionDOMUI::ProcessDOMUIMessage(const std::string& message,
                                          const Value* content,
                                          int request_id,
                                          bool has_callback) {
   extension_function_dispatcher_->HandleRequest(message, content, request_id,
                                                 has_callback);
 }
 
@@ skipping 200 matching lines @@
       // If it's being unregistered, it should already be in the list.
       NOTREACHED();
       continue;
     } else {
       StringValue override((*iter).second.spec());
       UnregisterAndReplaceOverride((*iter).first, profile,
                                    page_overrides, &override);
     }
   }
 }