Issue 596102: Enter_chroot: Mount chrome browser source inside chroot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 596102: Enter_chroot: Mount chrome browser source inside chroot. (Closed)

Created:
10 years, 10 months ago by adlr

Modified:
9 years ago

Reviewers:
DaveMoore

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

Enter_chroot: Mount chrome browser source inside chroot. If one passes --chrome_root=.../path/to/chrome_root/outside/chroot to enter_chroot.sh once, enter_chroot will make a note inside the croot and mount it on all subsequent calls to enter_chroot, even if the argument is not passed again. If ever enter_chroot can't find the proper dir, it deletes any stored note. chrome_root must contain a "src" subdirectory.

Patch Set 1 #

Total comments: 1

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -0 lines)			Patch
	M	src/scripts/enter_chroot.sh	View		3 chunks	+25 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

DaveMoore

10 years, 10 months ago (2010-02-12 22:31:12 UTC) #2

LGTM

http://codereview.chromium.org/596102/diff/1/2
File src/scripts/enter_chroot.sh (right):

http://codereview.chromium.org/596102/diff/1/2#newcode109
src/scripts/enter_chroot.sh:109: echo "Mouting chrome source at:
$INNER_CHROME_ROOT"
nit: spelling

Expand Messages | Collapse Messages