Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issue 5961016: Optimize array-length and fast element loads.... (Closed)

Created:
9 years, 11 months ago by fschneider
Modified:
9 years, 6 months ago
Reviewers:
Vitaly Repeshko
CC:
v8-dev
Visibility:
Public.

Description

Optimize array-length and fast element loads. 1. Separating out the instance-type check from the array-length operation. 2. I also changed the bounds-check on keyed loads to use the length property for JS arrays (like we do for array stores). The new pattern should use less registers and allow more checks to be eliminated. Committed: http://code.google.com/p/v8/source/detail?r=6125

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -85 lines) Patch
M src/arm/lithium-arm.h View 1 2 5 chunks +15 lines, -10 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 2 1 chunk +7 lines, -11 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 1 chunk +10 lines, -15 lines 0 comments Download
M src/hydrogen.cc View 1 2 4 chunks +18 lines, -6 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 7 chunks +23 lines, -5 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 2 chunks +8 lines, -17 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 2 7 chunks +15 lines, -10 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 2 1 chunk +7 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
fschneider
9 years, 11 months ago (2010-12-30 14:30:24 UTC) #1
fschneider
Added ARM files and addressed off-line comments.
9 years, 11 months ago (2010-12-30 19:29:48 UTC) #2
Vitaly Repeshko
9 years, 11 months ago (2010-12-31 11:53:46 UTC) #3
Still LGTM!

Powered by Google App Engine
This is Rietveld 408576698