Give user the ability to disable the URL request throttler:...

Give user the ability to disable the URL request throttler:
- Support the command line switch --disable-enforced-throttling. With this switch specified, the URL request throttler won't reject outgoing requests during the back-off peroid. Please note that in this case we still keep track of the back-off period, since we need it to determine retry intervals.
- Add a more detailed error page description for net::ERR_TEMPORARILY_THROTTLED.

BUG=66062
TEST=Without --disable-enforced-throttling switch:
  (1) Type in the addresss bar a URL which is expected to return 5XX.
  (2) Keep clicking the "reload" button.
  (3) After a few clicks, Chrome displays an error page explaining why a net::ERR_TEMPORARILY_THROTTLED error occurs.

With --disable-enforced-throttling switch:
  Following step (1) and (2) described above won't result in a net::ERR_TEMPORARILY_THROTTLED error page.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70022

[willchan no longer on Chromium, 2010-12-22 22:37:26]

LGTM

http://codereview.chromium.org/5961008/diff/9001/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/5961008/diff/9001/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:6258: It is likely that the server hosting
the webpage has been overloaded or encountered an error. In order to avoid
causing too much traffic and making the situation worse, <ph
name="PRODUCT_NAME">&lt;span jscontent="productName"&gt;&lt;/span&gt;<ex>Google
Chrome</ex></ph> temporarily stops sending requests to the server.
Grammar nit:
s/temporarily stops/has temporarily stopped/

[Jói, 2010-12-22 22:44:48]

LGTM with a couple of nits.

http://codereview.chromium.org/5961008/diff/9001/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/5961008/diff/9001/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:6257: <message
name="IDS_ERRORPAGES_SUMMARY_TEMPORARILY_THROTTLED" desc="Summary in the error
page when we temporarily stop sending requests to a server in order to avoid
DDoS.">
The names of this constant (..._SUMMARY_...) and the one below (..._DETAILS_...)
make it sound like this first one should be the shorter message, and the one
below should be the longer explanation. You're sure you didn't invert these?

http://codereview.chromium.org/5961008/diff/9001/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:6258: It is likely that the server hosting
the webpage has been overloaded or encountered an error. In order to avoid
causing too much traffic and making the situation worse, <ph
name="PRODUCT_NAME">&lt;span jscontent="productName"&gt;&lt;/span&gt;<ex>Google
Chrome</ex></ph> temporarily stops sending requests to the server.
Shouldn't this be "has temporarily stopped allowing requests" (rather than
"sending")?

[yzshen1, 2010-12-22 23:04:35]

Thanks!

http://codereview.chromium.org/5961008/diff/9001/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/5961008/diff/9001/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:6257: <message
name="IDS_ERRORPAGES_SUMMARY_TEMPORARILY_THROTTLED" desc="Summary in the error
page when we temporarily stop sending requests to a server in order to avoid
DDoS.">
On 2010/12/22 22:44:49, Jói wrote:
> The names of this constant (..._SUMMARY_...) and the one below
(..._DETAILS_...)
> make it sound like this first one should be the shorter message, and the one
> below should be the longer explanation. You're sure you didn't invert these?

As far as I know, the "summary" section is the main body of the page; while the
"details" section describes the meaning of the error code.
Quite a lot of error pages have "summary" longer than "details". For example,
right above the messages I added,
IDS_ERRORPAGES_SUMMARY_BAD_SSL_CLIENT_AUTH_CERT is much longer than
IDS_ERRORPAGES_DETAILS_BAD_SSL_CLIENT_AUTH_CERT.

http://codereview.chromium.org/5961008/diff/9001/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:6258: It is likely that the server hosting
the webpage has been overloaded or encountered an error. In order to avoid
causing too much traffic and making the situation worse, <ph
name="PRODUCT_NAME">&lt;span jscontent="productName"&gt;&lt;/span&gt;<ex>Google
Chrome</ex></ph> temporarily stops sending requests to the server.
On 2010/12/22 22:37:26, willchan wrote:
> Grammar nit:
> s/temporarily stops/has temporarily stopped/

Done.

http://codereview.chromium.org/5961008/diff/9001/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:6258: It is likely that the server hosting
the webpage has been overloaded or encountered an error. In order to avoid
causing too much traffic and making the situation worse, <ph
name="PRODUCT_NAME">&lt;span jscontent="productName"&gt;&lt;/span&gt;<ex>Google
Chrome</ex></ph> temporarily stops sending requests to the server.
On 2010/12/22 22:44:49, Jói wrote:
> Shouldn't this be "has temporarily stopped allowing requests" (rather than
> "sending")?

Done.

[Jói, 2010-12-23 12:23:11]

LGTM

[Dashu, 2011-01-24 14:40:09]

On 2010/12/23 12:23:11, Jói wrote:
> LGTM

Why oh why is this activated for localhost sites?