chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.mm - Issue 5961007: Move nsimage_cache from base to app/mac. Use the app::mac namespace. Update c...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.mm

Issue 5961007: Move nsimage_cache from base to app/mac. Use the app::mac namespace. Update c... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« app/mac/nsimage_cache.h ('K') | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm » ('j') | chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.mm

===================================================================

--- chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.mm (revision 69953)

+++ chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.mm (working copy)

@@ -5,7 +5,7 @@

#import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.h"

#import "base/logging.h"

-#include "base/nsimage_cache_mac.h"

+#include "app/mac/nsimage_cache.h"

#import "base/scoped_nsobject.h"

#import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h"

#import "chrome/browser/ui/cocoa/image_utils.h"

@@ -41,10 +41,10 @@

@implementation BookmarkBarFolderWindowContentView

- (void)awakeFromNib {

- arrowUpImage_.reset([nsimage_cache::ImageNamed(@"menu_overflow_up.pdf")

+ arrowUpImage_.reset([app::mac::GetCachedImageWithName(@"menu_overflow_up.pdf")

retain]);

Avi (use Gerrit) 2010/12/22 19:06:38 Wrap this line like you wrapped the one below.

- arrowDownImage_.reset([nsimage_cache::ImageNamed(@"menu_overflow_down.pdf")

- retain]);

+ arrowDownImage_.reset(

+ [app::mac::GetCachedImageWithName(@"menu_overflow_down.pdf") retain]);

}

// Draw the arrows at the top and bottom of the folder window as a