Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5961007: Move nsimage_cache from base to app/mac. Use the app::mac namespace. Update c... (Closed)

Created:
9 years, 12 months ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, Erik does not do reviews, brettw-cc_chromium.org, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org
Visibility:
Public.

Description

Move nsimage_cache from base to app/mac. Use the app::mac namespace. Update calling code. Remove unnecessary refs to NullableString from render_thread.* TEST=it compiles BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69973

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 10

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -223 lines) Patch
M app/app_base.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A + app/mac/nsimage_cache.h View 3 chunks +11 lines, -9 lines 0 comments Download
A + app/mac/nsimage_cache.mm View 3 chunks +7 lines, -5 lines 0 comments Download
A app/mac/nsimage_cache_unittest.cc.README View 1 chunk +3 lines, -0 lines 0 comments Download
M base/base.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D base/compat_execinfo.h View 1 chunk +0 lines, -34 lines 0 comments Download
D base/nsimage_cache_mac.h View 1 chunk +0 lines, -33 lines 0 comments Download
D base/nsimage_cache_mac.mm View 1 chunk +0 lines, -73 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/animatable_image_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.mm View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/notifications/balloon_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/nsimage_cache_unittest.mm View 3 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/reload_button.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/search_engine_dialog_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_strip_controller.mm View 1 2 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_view.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/toolbar_controller.mm View 1 2 3 chunks +12 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/web_contents_drag_source.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/web_drag_source.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/render_thread.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/render_thread.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/glue/webcursor_mac.mm View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
brettw
http://codereview.chromium.org/5961007/diff/7001/chrome/renderer/render_thread.h File chrome/renderer/render_thread.h (left): http://codereview.chromium.org/5961007/diff/7001/chrome/renderer/render_thread.h#oldcode33 chrome/renderer/render_thread.h:33: class NullableString16; This change is on purpose, I just ...
9 years, 12 months ago (2010-12-22 18:47:39 UTC) #1
Avi (use Gerrit)
http://codereview.chromium.org/5961007/diff/7001/app/mac/nsimage_cache.h File app/mac/nsimage_cache.h (right): http://codereview.chromium.org/5961007/diff/7001/app/mac/nsimage_cache.h#newcode27 app/mac/nsimage_cache.h:27: NSImage* GetCachedImageWithName(NSString* name); Why the name change? This does ...
9 years, 12 months ago (2010-12-22 19:06:37 UTC) #2
brettw
http://codereview.chromium.org/5961007/diff/7001/app/mac/nsimage_cache.h File app/mac/nsimage_cache.h (right): http://codereview.chromium.org/5961007/diff/7001/app/mac/nsimage_cache.h#newcode27 app/mac/nsimage_cache.h:27: NSImage* GetCachedImageWithName(NSString* name); app::mac::ImageNamed is too vague (more stuff ...
9 years, 12 months ago (2010-12-22 19:12:04 UTC) #3
Avi (use Gerrit)
OK.
9 years, 12 months ago (2010-12-22 19:20:49 UTC) #4
brettw
New snap up with line wrapping.
9 years, 12 months ago (2010-12-22 19:27:36 UTC) #5
Avi (use Gerrit)
9 years, 12 months ago (2010-12-22 19:34:26 UTC) #6 
LGTM

Powered by Google App Engine
This is Rietveld 408576698