Issue 596082: Optimize string plus smi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 596082: Optimize string plus smi... (Closed)

Created:
10 years, 10 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Optimize string plus smi When adding a string with a smi value the number string cache is checked in generated code. If the there is a string value in the number string cache the resulting string is produced in generated code. Committed: http://code.google.com/p/v8/source/detail?r=3843

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -7 lines)			Patch
M	src/ia32/assembler-ia32.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	1 2 3	2 chunks	+46 lines, -5 lines	0 comments	Download
M	src/v8-counters.h	View	1 2 3	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/596082/diff/6002/6003 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/596082/diff/6002/6003#newcode7677 src/ia32/codegen-ia32.cc:7677: __ IncrementCounter(not_equal, &Counters::string_puls_smi_miss, 1); puls -> plus

10 years, 10 months ago (2010-02-12 10:28:12 UTC) #2

Søren Thygesen Gjesse

10 years, 10 months ago (2010-02-12 11:49:53 UTC) #3

http://codereview.chromium.org/596082/diff/6002/6003
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/596082/diff/6002/6003#newcode7677
src/ia32/codegen-ia32.cc:7677: __ IncrementCounter(not_equal,
&Counters::string_puls_smi_miss, 1);
On 2010/02/12 10:28:12, Mads Ager wrote:
> puls -> plus

Done (I will should probably remove these counters again soon).

Expand Messages | Collapse Messages