Issue 596036: Port change in CallIC interface to x64 platform. Name of called function is ...

Issue 596036: Port change in CallIC interface to x64 platform. Name of called function is ... (Closed)

Created:
10 years, 10 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Port change in CallIC interface to x64 platform. Name of called function is now passed in rcx. Committed: http://code.google.com/p/v8/source/detail?r=3838

Patch Set 4 : '' #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+157 lines, -133 lines)			Patch
M	src/x64/builtins-x64.cc	View	1 2 3	1 chunk	+34 lines, -30 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1 2 3	7 chunks	+11 lines, -11 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	2 3	7 chunks	+8 lines, -12 lines	0 comments	Download
M	src/x64/ic-x64.cc	View	1 2 3	4 chunks	+32 lines, -20 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1 2 3	20 chunks	+62 lines, -53 lines	0 comments	Download
M	src/x64/virtual-frame-x64.h	View	1 2 3	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/x64/virtual-frame-x64.cc	View	1 2 3	1 chunk	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

William Hesse

There is currently a problem somewhere - CallIC_Miss is getting called without the name as ...

10 years, 10 months ago (2010-02-10 16:17:19 UTC) #1

Kevin Millikin (Chromium)

LGTM. http://codereview.chromium.org/596036/diff/4002/9005 File src/x64/ic-x64.cc (right): http://codereview.chromium.org/596036/diff/4002/9005#newcode986 src/x64/ic-x64.cc:986: // rcx : function name Make all the ...

10 years, 10 months ago (2010-02-11 12:03:12 UTC) #3

William Hesse

10 years, 10 months ago (2010-02-12 09:01:38 UTC) #4

http://codereview.chromium.org/596036/diff/4002/9005
File src/x64/ic-x64.cc (right):

http://codereview.chromium.org/596036/diff/4002/9005#newcode986
src/x64/ic-x64.cc:986: // rcx                      : function name
On 2010/02/11 12:03:13, Kevin Millikin wrote:
> Make all the CallIC "S t a t e" comments the same (as long as the state is the
> same).

Done.

http://codereview.chromium.org/596036/diff/4002/9002
File src/x64/virtual-frame-x64.cc (right):

http://codereview.chromium.org/596036/diff/4002/9002#newcode1022
src/x64/virtual-frame-x64.cc:1022: // Function name, arguments, and receiver,
and function name are found
On 2010/02/11 12:03:13, Kevin Millikin wrote:
> Function name listed twice.

Done.

http://codereview.chromium.org/596036/diff/4002/9003
File src/x64/virtual-frame-x64.h (right):

http://codereview.chromium.org/596036/diff/4002/9003#newcode350
src/x64/virtual-frame-x64.h:350: // Call call IC.  Function name, arguments, and
receiver, and function
On 2010/02/11 12:03:13, Kevin Millikin wrote:
> This comment mentions function name twice.

Done.

Expand Messages | Collapse Messages