Issue 596020: Prevent the user from triggering multiple copies of a particular exceptions w...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 596020: Prevent the user from triggering multiple copies of a particular exceptions w... (Closed)

Created:
10 years, 10 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Prevent the user from triggering multiple copies of a particular exceptions window. BUG=34692 TEST=Open the content settings dialog to any page, hit "Exceptions", move the exceptions window and hit "Exceptions" again; we shouldn't spawn another window. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38516

Patch Set 1 #

Total comments: 1

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -4 lines)			Patch
	M	chrome/browser/views/options/exceptions_view.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/views/options/exceptions_view.cc	View		1 chunk	+12 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

10 years, 10 months ago (2010-02-09 21:32:24 UTC) #2

LGTM

http://codereview.chromium.org/596020/diff/1/2
File chrome/browser/views/options/exceptions_view.cc (right):

http://codereview.chromium.org/596020/diff/1/2#newcode31
chrome/browser/views/options/exceptions_view.cc:31: // The window is alive by
itself now...
I don't get what this comment means.

Expand Messages | Collapse Messages