Issue 596011: Change GenerateLoadStringLength to have two scratch registers on all platform...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 596011: Change GenerateLoadStringLength to have two scratch registers on all platform... (Closed)

Created:
10 years, 10 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Change GenerateLoadStringLength to have two scratch registers on all platforms. This is needed so that the LoadIC can pass the receiver in a register, and not have it overwritten, and also simplifies the code. Committed: http://code.google.com/p/v8/source/detail?r=3820

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -25 lines)			Patch
M	src/arm/ic-arm.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/stub-cache-arm.cc	View	1	2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/ia32/ic-ia32.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	1	3 chunks	+7 lines, -6 lines	0 comments	Download
M	src/stub-cache.h	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/x64/ic-x64.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1	3 chunks	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

A tiny review for you.

Expand Messages | Collapse Messages