Issue 5959009: Allow getters and setters on JSArray elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5959009: Allow getters and setters on JSArray elements. (Closed)

Created:
9 years, 11 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Allow getters and setters on JSArray elements. This fixes bug 900 Committed: http://code.google.com/p/v8/source/detail?r=6158

Patch Set 1 #

Total comments: 2

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -18 lines)			Patch
M	src/objects.cc	View	3 chunks	+2 lines, -3 lines	2 comments	Download
M	test/mjsunit/indexed-accessors.js	View	1 chunk	+0 lines, -13 lines	0 comments	Download
A	test/mjsunit/regress/regress-900.js	View	1 chunk	+46 lines, -0 lines	0 comments	Download
M	test/mozilla/mozilla.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/5959009/diff/1/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/5959009/diff/1/src/objects.cc#newcode6949 src/objects.cc:6949: if (SetElementWithCallbackSetterInPrototypes(index, value)) { For the heck of ...

9 years, 11 months ago (2011-01-04 13:34:34 UTC) #2

Rico

9 years, 11 months ago (2011-01-04 13:57:50 UTC) #3

http://codereview.chromium.org/5959009/diff/1/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/5959009/diff/1/src/objects.cc#newcode6949
src/objects.cc:6949: if (SetElementWithCallbackSetterInPrototypes(index, value))
{
On 2011/01/04 13:34:34, Lasse Reichstein wrote:
> For the heck of it, combine the two ifs into one.

Done.

Expand Messages | Collapse Messages