Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: chrome_frame/chrome_frame_automation.cc

Issue 5959006: Revert 70144 and 70145 and add a build fix. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/chrome_frame_automation.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/chrome_frame_automation.cc
===================================================================
--- chrome_frame/chrome_frame_automation.cc (revision 70145)
+++ chrome_frame/chrome_frame_automation.cc (working copy)
@@ -73,13 +73,14 @@
// Get AddRef-ed pointer to corresponding TabProxy object
TabProxy* tab = static_cast<TabProxy*>(tracker_->GetResource(
message.routing_id()));
+ bool handled = false;
if (tab) {
tab->OnMessageReceived(message);
- tab->Release();
+ handled = tab->Release();
} else {
DLOG(ERROR) << "Failed to find TabProxy for tab:" << message.routing_id();
}
- return true;
+ return handled;
}
virtual void OnChannelError() {
@@ -1168,19 +1169,20 @@
// kind of beings.
// By default we marshal the IPC message to the main/GUI thread and from there
// we safely invoke chrome_frame_delegate_->OnMessageReceived(msg).
-void ChromeFrameAutomationClient::OnMessageReceived(TabProxy* tab,
+bool ChromeFrameAutomationClient::OnMessageReceived(TabProxy* tab,
const IPC::Message& msg) {
DCHECK(tab == tab_.get());
// Quickly process network related messages.
if (url_fetcher_ && ProcessUrlRequestMessage(tab, msg, false))
- return;
+ return true;
// Early check to avoid needless marshaling
if (chrome_frame_delegate_ == NULL)
- return;
+ return false;
PostTask(FROM_HERE, NewRunnableMethod(this,
&ChromeFrameAutomationClient::OnMessageReceivedUIThread, msg));
+ return true;
}
void ChromeFrameAutomationClient::OnChannelError(TabProxy* tab) {
« no previous file with comments | « chrome_frame/chrome_frame_automation.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698