Issue 5958005: DOMUI: Rename download path 'Browse...' button to 'Change...'

Issue 5958005: DOMUI: Rename download path 'Browse...' button to 'Change...' (Closed)

Created:
10 years ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
csilv, James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

DOMUI: Rename download path 'Browse...' button to 'Change...' BUG=41767 TEST=visual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69684

Patch Set 2 : add TODO #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -7 lines)			Patch
M	chrome/app/generated_resources.grd	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/options/advanced_options_handler.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/options/advanced_options.html	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/options/advanced_options.js	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

http://codereview.chromium.org/5958005/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/5958005/diff/1/chrome/app/generated_resources.grd#newcode6834 chrome/app/generated_resources.grd:6834: <message name="IDS_OPTIONS_DOWNLOADLOCATION_BROWSE_BUTTON" desc="The label of the 'Browse...' button"> Add ...

10 years ago (2010-12-19 16:48:38 UTC) #2

tfarina

10 years ago (2010-12-19 16:57:51 UTC) #3

LGTM

Expand Messages | Collapse Messages