Issue 5958002: Do not show apps section until default apps are installed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5958002: Do not show apps section until default apps are installed. (Closed)

Created:
10 years ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, arv (Not doing code reviews), pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Do not show apps section until default apps are installed. The referenced bugs were side-effects of this underlying issue. BUG=67073, 67075 TEST=Run chrome on new profile. Apps section should not show up initially. Go to chrome://extensions/ -> developer mode, and click 'update now'. Apps should show up along with promo. Uninstall all apps. Apps section should keep showing up. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69758

Patch Set 1 #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -3 lines)			Patch
M	chrome/browser/dom_ui/app_launcher_handler.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/default_apps.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/resources/new_new_tab.html	View	2 chunks	+15 lines, -1 line	1 comment	Download
M	chrome/browser/resources/ntp/apps.js	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

10 years ago (2010-12-17 21:55:35 UTC) #2

LGTM but the "This is insane..." comment scares me. We should just fix it, it
cannot be that hard (famous last words)

http://codereview.chromium.org/5958002/diff/1/chrome/browser/resources/new_ne...
File chrome/browser/resources/new_new_tab.html (right):

http://codereview.chromium.org/5958002/diff/1/chrome/browser/resources/new_ne...
chrome/browser/resources/new_new_tab.html:323: // This is insane, but we use the
CSS class 'disabled' for both 'minimized'
Is it worth fixing this first?

Expand Messages | Collapse Messages