Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Issue 595022: Harden global variable accesses in the fast code generator. (Closed)

Created:
10 years, 10 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Harden global variable accesses in the fast code generator. Explicitly check that global variables do not have accessors or interceptors in the fast code generator syntax checker. Committed: http://code.google.com/p/v8/source/detail?r=3828

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -9 lines) Patch
M src/fast-codegen.cc View 2 chunks +13 lines, -3 lines 0 comments Download
M test/mjsunit/compiler/simple-global-access.js View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
10 years, 10 months ago (2010-02-10 13:21:04 UTC) #1
Mads Ager (chromium)
10 years, 10 months ago (2010-02-10 13:23:46 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698