[Mac] Use the ExtensionToolbarModel for ordering of the Browser Actions. Prep...

[Mac] Use the ExtensionToolbarModel for ordering of the Browser Actions. Prep for drag and drop for re-ordering.
Also fixes crashers where if you tried to disable an extension via its context menu while an incognito window was key, boom.

BUG=26990
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38632

[Finnur, 2010-02-10 04:50:02]

I'm afraid you'll have to rely on Mark for this changelist. It contains code in
some weird bracket language that I'm not familiar with... ;)

[Erik does not do reviews, 2010-02-10 16:57:41]

If you need someone from extensions to review these, you can bounce it to me. 
I'm familiar with this dialect. :)

Overall, LGTM.  Did you intent to combine the context menu changes in this CL? 
If so, please update the description of the CL to match.

http://codereview.chromium.org/595017/diff/8001/9004
File chrome/browser/cocoa/extensions/browser_actions_controller.mm (right):

http://codereview.chromium.org/595017/diff/8001/9004#newcode93
chrome/browser/cocoa/extensions/browser_actions_controller.mm:93: if
(!extensionsService) {  // |extensionsService| can be NULL in Incognito.
FYI, this is going to change soon (see http://codereview.chromium.org/567037). 
This will affect this code (order and position is handled a little differently),
but no need to change anything here for now though.

http://codereview.chromium.org/595017/diff/8001/9004#newcode161
chrome/browser/cocoa/extensions/browser_actions_controller.mm:161:
[containerView_ setNeedsDisplay:YES];
I thought adding and removing subviews always set this automatically.  It
obviously doesn't hurt, but just curious.

[Bons, 2010-02-10 17:52:30]

The description was updated.

Thanks for the review, Erik.

http://codereview.chromium.org/595017/diff/8001/9004
File chrome/browser/cocoa/extensions/browser_actions_controller.mm (right):

http://codereview.chromium.org/595017/diff/8001/9004#newcode161
chrome/browser/cocoa/extensions/browser_actions_controller.mm:161:
[containerView_ setNeedsDisplay:YES];
On 2010/02/10 16:57:41, Erik Kay wrote:
> I thought adding and removing subviews always set this automatically.  It
> obviously doesn't hurt, but just curious.

I don't see anything in the docs, but also, we want to redisplay _after_ we
reposition the action buttons.

[Mark Mentovai, 2010-02-11 17:40:25]

LGTM