Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1511)

Unified Diff: src/scripts/common.sh

Issue 595009: Add a warning to users trying to run old build scripts. (Closed)
Patch Set: new2 Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/scripts/common.sh
diff --git a/src/scripts/common.sh b/src/scripts/common.sh
index 184642ab51932c07dc65960bdf460e243b6f5493..e613df58ebdbb4cbff1d18452d88e4dcb94cb740 100644
--- a/src/scripts/common.sh
+++ b/src/scripts/common.sh
@@ -108,6 +108,28 @@ fi
# Directory locations inside the dev chroot
CHROOT_TRUNK_DIR="/home/$USER/trunk"
+# Check to ensure not running old scripts
+V_REVERSE=''
+V_VIDOFF=''
+case "$(basename $0)" in
+ build_image.sh|build_platform_packages.sh|customize_rootfs.sh|make_chroot.sh)
+ echo
+ echo "$V_REVERSE============================================================"
+ echo "=========================== WARNING ======================"
+ echo "============================================================$V_VIDOFF"
+ echo
+ echo "RUNNING OLD BUILD SYSTEM SCRIPTS. RUN THE PORTAGE-BASED BUILD HERE:"
+ echo "http://www.chromium.org/chromium-os/building-chromium-os/portage-based-build"
+ echo
+ if [ "$USER" != "chrome-bot" ]
+ then
+ read -n1 -p "Press any key to continue using the OLD build system..."
+ echo
+ echo
+ fi
+ ;;
+esac
+
# -----------------------------------------------------------------------------
# Functions
@@ -193,7 +215,7 @@ function install_if_missing {
#
# $1 - The file to check
is_whitelisted() {
- local file=$1
+ local file=$1
local whitelist="$FLAGS_whitelist"
test -f "$whitelist" || (echo "Whitelist file missing ($whitelist)" && exit 1)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698