base/test/mock_chrome_application_mac.h - Issue 5950003: Remove CrApplication dependency from base

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/test/mock_chrome_application_mac.h

Issue 5950003: Remove CrApplication dependency from base (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/base

Patch Set: '' Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef BASE_TEST_MOCK_CHROME_APPLICATION_MAC_H_

	6 #define BASE_TEST_MOCK_CHROME_APPLICATION_MAC_H_

	7 #pragma once

	8
	Mark Mentovai 2010/12/17 17:31:38 Extra blank line. Extra blank line. Nico 2010/12/18 01:14:28 Done. Show quoted text On 2010/12/17 17:31:38, Mark Mentovai wrote: > Extra blank line. Done.
	9

	10 #ifdef __OBJC__
	Mark Mentovai 2010/12/17 17:31:38 Chromium code prefers #if defined(__OBJC__). Chromium code prefers #if defined(__OBJC__). Nico 2010/12/18 01:14:28 Done. Show quoted text On 2010/12/17 17:31:38, Mark Mentovai wrote: > Chromium code prefers #if defined(__OBJC__). Done.
	11

	12 #import <Cocoa/Cocoa.h>
	Mark Mentovai 2010/12/17 17:31:38 You can get away with just AppKit/AppKit.h. You can get away with just AppKit/AppKit.h. Nico 2010/12/18 01:14:28 Done. Show quoted text On 2010/12/17 17:31:38, Mark Mentovai wrote: > You can get away with just AppKit/AppKit.h. Done.
	13

	14 #include "base/message_pump_mac.h"

	15

	16 // A mock implementation of CrAppProtocol that claims that -sendEvent: is never

	17 // on the stack. This can be used in tests that need an NSApplication and which
	dmac 2010/12/17 18:00:16 I think you can get rid of both "whichs" in the la I think you can get rid of both "whichs" in the last sentence. Nico 2010/12/18 01:14:28 Done. Show quoted text On 2010/12/17 18:00:16, dmac wrote: > I think you can get rid of both "whichs" in the last sentence. Done.
	18 // use a runloop, but which don't run nested message loops.

	19 @interface MockCrApp : NSApplication<CrAppProtocol>

	20 @end

	21

	22 #endif

	23

	24 // To be used to instantiate MockCrApp from C++ code.

	25 namespace mock_cr_app {

	26 void RegisterMockCrApp();

	27 }
	Mark Mentovai 2010/12/17 17:31:38 } // namespace mock_cr_app } // namespace mock_cr_app Nico 2010/12/18 01:14:28 Done. Show quoted text On 2010/12/17 17:31:38, Mark Mentovai wrote: > } // namespace mock_cr_app Done.
	28

	29 #endif // BASE_TEST_MOCK_CHROME_APPLICATION_MAC_H_

OLD	NEW

« base/message_pump_mac.mm ('K') | « base/message_pump_mac.mm ('k') | base/test/mock_chrome_application_mac.mm » ('j') | webkit/tools/test_shell/test_shell_platform_delegate_mac.mm » ('J')