Issue 5950001: Change DefaultString and DefaultNumber to match the spec required behavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5950001: Change DefaultString and DefaultNumber to match the spec required behavior. (Closed)

Created:
10 years ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Rico

CC:
v8-dev

Visibility:
Public.

Description

Change DefaultString and DefaultNumber to match the spec required behavior. Previously it did two reads of the .toString and .valueOf properties where only one was allowed.

Patch Set 1 #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -8 lines)			Patch
	M	src/runtime.js	View		2 chunks	+12 lines, -8 lines	0 comments	Download
	A	test/mjsunit/object-toprimitive.js	View		1 chunk	+104 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

The two functions are implementing the spec function ToPrimitive with hint Number and String.

10 years ago (2010-12-16 12:09:54 UTC) #1

Rico

10 years ago (2010-12-16 12:19:51 UTC) #2

LGTM

http://codereview.chromium.org/5950001/diff/1/test/mjsunit/object-toprimitive.js
File test/mjsunit/object-toprimitive.js (right):

http://codereview.chromium.org/5950001/diff/1/test/mjsunit/object-toprimitive...
test/mjsunit/object-toprimitive.js:42: function traceValueOf () {
indention

Expand Messages | Collapse Messages