As the first step in an effort to improve robustness of the cloud print proxy...

chrome/service/service_utility_process_host.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/service/service_utility_process_host.h"
 
 #include "app/app_switches.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/message_loop.h"
@@ skipping 29 matching lines @@
   return false;
 #else  // !defined(OS_WIN)
   scratch_metafile_dir_.reset(new ScopedTempDir);
   if (!scratch_metafile_dir_->CreateUniqueTempDir())
     return false;
   if (!file_util::CreateTemporaryFileInDir(scratch_metafile_dir_->path(),
                                            &metafile_path_)) {
     return false;
   }
 
-  if (!StartProcess(scratch_metafile_dir_->path()))
+  if (!StartProcess(false, scratch_metafile_dir_->path()))
     return false;
 
   ScopedHandle pdf_file(
       ::CreateFile(pdf_path.value().c_str(),
                    GENERIC_READ,
                    FILE_SHARE_READ | FILE_SHARE_WRITE,
                    NULL,
                    OPEN_EXISTING,
                    FILE_ATTRIBUTE_NORMAL,
                    NULL));
   if (pdf_file == INVALID_HANDLE_VALUE)
     return false;
   HANDLE pdf_file_in_utility_process = NULL;
   ::DuplicateHandle(::GetCurrentProcess(), pdf_file, handle(),
                     &pdf_file_in_utility_process, 0, false,
                     DUPLICATE_SAME_ACCESS);
   if (!pdf_file_in_utility_process)
     return false;
   waiting_for_reply_ = true;
   return Send(
       new UtilityMsg_RenderPDFPagesToMetafile(pdf_file_in_utility_process,
                                               metafile_path_,
                                               render_area,
                                               render_dpi,
                                               page_ranges));
 #endif  // !defined(OS_WIN)
 }
 
-bool ServiceUtilityProcessHost::StartProcess(const FilePath& exposed_dir) {
+bool ServiceUtilityProcessHost::StartGetPrinterCapsAndDefaults(
+    const std::string& printer_name) {
+  FilePath exposed_path;
+  if (!StartProcess(true, exposed_path))
+    return false;
+  waiting_for_reply_ = true;
+  return Send(new UtilityMsg_GetPrinterCapsAndDefaults(printer_name));
+}
+
+bool ServiceUtilityProcessHost::StartProcess(bool no_sandbox,
+                                             const FilePath& exposed_dir) {
   // Name must be set or metrics_service will crash in any test which
   // launches a UtilityProcessHost.
   set_name(L"utility process");
 
   if (!CreateChannel())
     return false;
 
   FilePath exe_path = GetUtilityProcessCmd();
   if (exe_path.empty()) {
     NOTREACHED() << "Unable to get utility process binary name.";
     return false;
   }
 
   CommandLine cmd_line(exe_path);
   cmd_line.AppendSwitchASCII(switches::kProcessType, switches::kUtilityProcess);
   cmd_line.AppendSwitchASCII(switches::kProcessChannelID, channel_id());
   cmd_line.AppendSwitch(switches::kLang);
+  if (no_sandbox)
+    cmd_line.AppendSwitch(switches::kNoSandbox);

[gene, 2010/12/20 22:52:31]

Why this is needed? Since we are passing no_sandbox flag to the down layer, this
should probably be taken care of already, right?

[sanjeevr, 2010/12/21 21:28:45]

Moved to lower layer.

 
-  return Launch(&cmd_line, exposed_dir);
+  return Launch(&cmd_line, no_sandbox, exposed_dir);
 }
 
 FilePath ServiceUtilityProcessHost::GetUtilityProcessCmd() {
   return GetChildPath(true);
 }
 
 bool ServiceUtilityProcessHost::CanShutdown() {
   return true;
 }
 
@@ skipping 51 matching lines @@
                         metafile_path_,
                         highest_rendered_page_number));
   waiting_for_reply_ = false;
 }
 
 void ServiceUtilityProcessHost::Client::OnMessageReceived(
     const IPC::Message& message) {
   IPC_BEGIN_MESSAGE_MAP(ServiceUtilityProcessHost, message)
     IPC_MESSAGE_HANDLER(UtilityHostMsg_RenderPDFPagesToMetafile_Failed,
                         Client::OnRenderPDFPagesToMetafileFailed)
+    IPC_MESSAGE_HANDLER(UtilityHostMsg_GetPrinterCapsAndDefaults_Succeeded,
+                        Client::OnGetPrinterCapsAndDefaultsSucceeded)
+    IPC_MESSAGE_HANDLER(UtilityHostMsg_GetPrinterCapsAndDefaults_Failed,
+                        Client::OnGetPrinterCapsAndDefaultsFailed)
   IPC_END_MESSAGE_MAP_EX()
 }
 
 void ServiceUtilityProcessHost::Client::MetafileAvailable(
     const FilePath& metafile_path,
     int highest_rendered_page_number) {
   // The metafile was created in a temp folder which needs to get deleted after
   // we have processed it.
   ScopedTempDir scratch_metafile_dir;
   scratch_metafile_dir.Set(metafile_path.DirName());
 #if defined(OS_WIN)
   printing::NativeMetafile metafile;
   if (!metafile.CreateFromFile(metafile_path)) {
     OnRenderPDFPagesToMetafileFailed();
   } else {
     OnRenderPDFPagesToMetafileSucceeded(metafile, highest_rendered_page_number);
     // Close it so that ScopedTempDir can delete the folder.
     metafile.CloseEmf();
   }
 #endif  // defined(OS_WIN)
 }