Make Graphics3D::SwapBuffers take a completion callback

webkit/glue/plugins/pepper_graphics_3d.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/glue/plugins/pepper_graphics_3d.h"
 
 #include "gpu/command_buffer/common/command_buffer.h"
 #include "base/lazy_instance.h"
 #include "base/thread_local.h"
 #include "ppapi/c/dev/ppb_graphics_3d_dev.h"
@@ skipping 76 matching lines @@
     scoped_refptr<Graphics3D> context(Resource::GetAs<Graphics3D>(graphics3d));
     return BoolToPPBool(context.get() && context->MakeCurrent());
   }
 }
 
 PP_Resource GetCurrentContext() {
   Graphics3D* current_context = Graphics3D::GetCurrent();
   return current_context ? current_context->GetReference() : 0;
 }
 
-PP_Bool SwapBuffers(PP_Resource graphics3d) {
+PP_Bool SwapBuffers(PP_Resource graphics3d, PP_CompletionCallback callback) {
   scoped_refptr<Graphics3D> context(Resource::GetAs<Graphics3D>(graphics3d));
-  return BoolToPPBool(context && context->SwapBuffers());
+  return BoolToPPBool(context && context->SwapBuffers(callback));
 }
 
 uint32_t GetError() {
   // Technically, this should return the last error that occurred on the current
   // thread, rather than an error associated with a particular context.
   // TODO(apatrick): Fix this.
   Graphics3D* current_context = Graphics3D::GetCurrent();
   if (!current_context)
     return 0;
 
@@ skipping 11 matching lines @@
   &MakeCurrent,
   &GetCurrentContext,
   &SwapBuffers,
   &GetError
 };
 
 }  // namespace
 
 Graphics3D::Graphics3D(PluginModule* module)
   : Resource(module),
-    bound_instance_(NULL) {
+    bound_instance_(NULL),
+    swap_initiated_(false),
+    swap_callback_(PP_BlockUntilComplete()) {
 }
 
 const PPB_Graphics3D_Dev* Graphics3D::GetInterface() {
   return &ppb_graphics3d;
 }
 
 Graphics3D* Graphics3D::GetCurrent() {
   return g_current_context_key.Get().Get();
 }
 
@@ skipping 60 matching lines @@
 bool Graphics3D::MakeCurrent() {
   if (!platform_context_.get())
     return false;
 
   g_current_context_key.Get().Set(this);
 
   // TODO(apatrick): Return false on context lost.
   return true;
 }
 
-bool Graphics3D::SwapBuffers() {
+bool Graphics3D::SwapBuffers(PP_CompletionCallback callback) {
   if (!platform_context_.get())
     return false;
 
+  if (swap_callback_.func) {
+    // Already a pending SwapBuffers that hasn't returned yet.
+    return false;
+  }
+
+  swap_callback_ = callback;
   return platform_context_->SwapBuffers();
 }
 
 unsigned Graphics3D::GetError() {
   if (!platform_context_.get())
     return 0;
 
   return platform_context_->GetError();
 }
 
 void Graphics3D::ResizeBackingTexture(const gfx::Size& size) {
   if (!platform_context_.get())
     return;
 
   platform_context_->ResizeBackingTexture(size);
 }
 
 void Graphics3D::SetSwapBuffersCallback(Callback0::Type* callback) {
   if (!platform_context_.get())
     return;
 
   platform_context_->SetSwapBuffersCallback(callback);
 }
 
+void Graphics3D::ViewInitiatedPaint() {
+  if (swap_callback_.func) {
+    swap_initiated_ = true;
+  }
+}
+
+void Graphics3D::ViewFlushedPaint() {
+  // Notify any "painted" callback. See |unpainted_flush_callback_| in the
+  // header for more.
+  if (swap_initiated_ && swap_callback_.func) {
+    // We must clear swap_callback_ before issuing the callback. It will be
+    // common for the plugin to issue another SwapBuffers in response to the
+    // callback, and we don't want to think that a callback is already pending.
+    PP_CompletionCallback callback = PP_BlockUntilComplete();
+    std::swap(callback, swap_callback_);
+    swap_initiated_ = false;
+    PP_RunCompletionCallback(&callback, PP_OK);
+  }
+}
+
 unsigned Graphics3D::GetBackingTextureId() {
   if (!platform_context_.get())
     return 0;
 
   return platform_context_->GetBackingTextureId();
 }
 
 void Graphics3D::Destroy() {
   if (GetCurrent() == this) {
     ResetCurrent();
   }
 
   gles2_implementation_ = NULL;
 
   platform_context_.reset();
 }
 
 }  // namespace pepper