Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: tools/emacs/trybot.el

Issue 5941003: emacs: make trybot parser work on offical windows build output (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/sanitize-win-build-log.sh ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/emacs/trybot.el
diff --git a/tools/emacs/trybot.el b/tools/emacs/trybot.el
index 0352ed5568fc28cdf4e699862b925279d16b1b0f..2c658976f06001388e10fdb5e292ad56c370602f 100644
--- a/tools/emacs/trybot.el
+++ b/tools/emacs/trybot.el
@@ -103,11 +103,15 @@
(switch-to-buffer (process-buffer process))
(when (equal state "finished\n")
(trybot-fixup (process-get process 'type-hint)))))
- (command (concat "curl -s " url
- (when (eq type-hint 'mac)
- ; Pipe it through the output shortener.
+ (command (concat "curl -s " (shell-quote-argument url)
+ ; Pipe it through the output shortener.
+ (cond
+ ((eq type-hint 'win)
(concat " | " (get-chrome-root)
- "build/sanitize-mac-build-log.sh")))))
+ "build/sanitize-win-build-log.sh"))
+ ((eq type-hint 'mac)
+ (concat " | " (get-chrome-root)
+ "build/sanitize-mac-build-log.sh"))))))
; Start up the subprocess.
(let* ((coding-system-for-read 'utf-8-dos)
@@ -154,7 +158,7 @@
(when (equal "stdio" (car (last (split-string url "/"))))
(setq url (concat url "/text")))
- (let ((type-hint (cond ((string-match "/win/" url) 'win)
+ (let ((type-hint (cond ((string-match "/[Ww]in" url) 'win)
((string-match "/mac/" url) 'mac)
; Match /linux, /linux_view, etc.
((string-match "/linux" url) 'linux)
« no previous file with comments | « build/sanitize-win-build-log.sh ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698