Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: chrome/browser/tab_contents/navigation_controller.h

Issue 594063: Plumb shift-reload down into newly-added shift-reload API. (Closed)
Patch Set: 80 Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tab_contents/navigation_controller.h
diff --git a/chrome/browser/tab_contents/navigation_controller.h b/chrome/browser/tab_contents/navigation_controller.h
index 2aba4fe80f415f700a946aefe4ad8414c14819b0..0ab746fe74c6580fb159bba254f32c2c0a1f8db2 100644
--- a/chrome/browser/tab_contents/navigation_controller.h
+++ b/chrome/browser/tab_contents/navigation_controller.h
@@ -133,6 +133,12 @@ class NavigationController {
int count;
};
+ enum ReloadType {
+ NO_RELOAD, // Normal load.
+ RELOAD_VALIDATING_CACHE, // Normal reload.
+ RELOAD_IGNORING_CACHE // Reload all subresources, aka shift-reload.
+ };
+
// ---------------------------------------------------------------------------
NavigationController(TabContents* tab_contents, Profile* profile);
@@ -286,6 +292,8 @@ class NavigationController {
// entry has POST data the user is prompted to see if they really want to
// reload the page. In nearly all cases pass in true.
void Reload(bool check_for_repost);
+ // Like Reload(), but don't use caches (aka "shift-reload").
+ void ReloadIgnoringCache(bool check_for_repost);
// Removing of entries -------------------------------------------------------
@@ -431,8 +439,11 @@ class NavigationController {
bool RendererDidNavigateAutoSubframe(
const ViewHostMsg_FrameNavigate_Params& params);
+ // Helper function for code shared between Reload() and ReloadAll().
+ void ReloadInternal(bool check_for_repost, ReloadType reload_type);
+
// Actually issues the navigation held in pending_entry.
- void NavigateToPendingEntry(bool reload);
+ void NavigateToPendingEntry(ReloadType reload_type);
// Allows the derived class to issue notifications that a load has been
// committed. This will fill in the active entry to the details structure.

Powered by Google App Engine
This is Rietveld 408576698