Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: chrome/browser/views/infobars/translate_infobars.cc

Issue 594056: Translate Infobars for OS X. (Closed)
Patch Set: Fix review comments Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/translate/translate_infobars_delegates.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/infobars/translate_infobars.cc
diff --git a/chrome/browser/views/infobars/translate_infobars.cc b/chrome/browser/views/infobars/translate_infobars.cc
index 1723c4b03dad6157842d9520532990cdffd97f20..fca63f5506216911420f6d8b386aa05833a7ada8 100644
--- a/chrome/browser/views/infobars/translate_infobars.cc
+++ b/chrome/browser/views/infobars/translate_infobars.cc
@@ -719,7 +719,8 @@ void TranslateInfoBar::OnLanguageModified(views::MenuButton* menu_button,
SchedulePaint();
// Clear options menu model so that it'll be created with new language.
options_menu_model_.reset();
- // If necessary, trigger translation.
+ // Selecting an item from the "from language" menu in the before translate
+ // phase shouldn't trigger translation - http://crbug.com/36666
if (GetDelegate()->state() == TranslateInfoBarDelegate::kAfterTranslate)
GetDelegate()->Translate();
}
« no previous file with comments | « chrome/browser/translate/translate_infobars_delegates.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698