Issue 594055: Change the interface of CallStubCompiler::CompileCallInterceptor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 594055: Change the interface of CallStubCompiler::CompileCallInterceptor. (Closed)

Created:
10 years, 10 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
William Hesse

CC:
v8-dev

Visibility:
Public.

Description

Change the interface of CallStubCompiler::CompileCallInterceptor. Move responsibility for a typecast into the caller so that it can be locally verified to succeed. Committed: http://code.google.com/p/v8/source/detail?r=3858

Patch Set 1 #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -10 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/stub-cache.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/stub-cache.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

10 years, 10 months ago (2010-02-15 12:39:51 UTC) #2

LGTM.

Identical changes should be made to ComputeCallField and CompileCallField.

Expand Messages | Collapse Messages