Issue 594054: Implement layoutTestController.numberOfPages.

Issue 594054: Implement layoutTestController.numberOfPages. (Closed)

Created:
10 years, 10 months ago by hamaji

Modified:
9 years, 5 months ago

Reviewers:
hayato, Yuzo

Visibility:
Public.

Description

Implement layoutTestController.numberOfPages. BUG=35215 TEST=layout tests

Patch Set 2 : remove an unnecessary comment #

Total comments: 6

Patch Set 3 : update per yuzo's suggestion #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -16 lines)			Patch
M	webkit/glue/webkit_glue.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	webkit/glue/webkit_glue.cc	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	webkit/tools/layout_tests/test_expectations.txt	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/layout_test_controller.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/layout_test_controller.cc	View	1 2	3 chunks	+45 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yuzo

LGTM http://codereview.chromium.org/594054/diff/1001/2004 File webkit/tools/test_shell/layout_test_controller.cc (right): http://codereview.chromium.org/594054/diff/1001/2004#newcode1075 webkit/tools/test_shell/layout_test_controller.cc:1075: static bool ParsePageParameters(const CppArgumentList& args, int arg_offset, float* ...

10 years, 10 months ago (2010-02-16 05:16:25 UTC) #2

hamaji

10 years, 10 months ago (2010-02-16 05:23:25 UTC) #3

Thanks for your review!

http://codereview.chromium.org/594054/diff/1001/2004
File webkit/tools/test_shell/layout_test_controller.cc (right):

http://codereview.chromium.org/594054/diff/1001/2004#newcode1075
webkit/tools/test_shell/layout_test_controller.cc:1075: static bool
ParsePageParameters(const CppArgumentList& args, int arg_offset, float*
page_width_in_pixels, float* page_height_in_pixels) {
On 2010/02/16 05:16:25, Yuzo wrote:
> > 80 cols

Oops. I forgot this is in Google styled code. My style is too optimized for
WebKit these days...

http://codereview.chromium.org/594054/diff/1001/2004#newcode1075
webkit/tools/test_shell/layout_test_controller.cc:1075: static bool
ParsePageParameters(const CppArgumentList& args, int arg_offset, float*
page_width_in_pixels, float* page_height_in_pixels) {
On 2010/02/16 05:16:25, Yuzo wrote:
> I think
>   ParsePageSizeParameters
> should more accurately describes what the function does.

I see. I thought eventually we may want to add other parameters, but yes, for
now your naming sounds better. Thanks!

http://codereview.chromium.org/594054/diff/1001/2004#newcode1088
webkit/tools/test_shell/layout_test_controller.cc:1088: case 0:  // fall
through.
On 2010/02/16 05:16:25, Yuzo wrote:
> I guess the fall through comment should be on the line before case 0?

Done.

Expand Messages | Collapse Messages