Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Issue 594006: Re-use .h code for both files. Add a license header. (Closed)

Created:
10 years, 10 months ago by djmm
Modified:
9 years, 7 months ago
Reviewers:
Chris Masone
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Re-use .h code for both files. Add a license header.

Patch Set 1 #

Total comments: 1

Patch Set 2 : localacct #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -17 lines) Patch
M src/scripts/enable_localaccount.sh View 1 2 chunks +12 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
djmm
10 years, 10 months ago (2010-02-09 02:33:05 UTC) #1
Chris Masone
http://codereview.chromium.org/594006/diff/1/2 File src/scripts/enable_localaccount.sh (right): http://codereview.chromium.org/594006/diff/1/2#newcode33 src/scripts/enable_localaccount.sh:33: ../platform/pam_offline/pam_localaccount.h the header generated for pam_offline puts kLocalAccount in ...
10 years, 10 months ago (2010-02-09 03:04:01 UTC) #2
Chris Masone
10 years, 10 months ago (2010-02-09 03:44:37 UTC) #3
On 2010/02/09 03:04:01, cmasone wrote:
> http://codereview.chromium.org/594006/diff/1/2
> File src/scripts/enable_localaccount.sh (right):
> 
> http://codereview.chromium.org/594006/diff/1/2#newcode33
> src/scripts/enable_localaccount.sh:33:
> ../platform/pam_offline/pam_localaccount.h
> the header generated for pam_offline puts kLocalAccount in a different
> namespace.

I bow to your script-fu.

lgtm

Powered by Google App Engine
This is Rietveld 408576698