Error handling added

chrome/browser/browser_main_mac.mm

Index: chrome/browser/browser_main_mac.mm
diff --git a/chrome/browser/browser_main_mac.mm b/chrome/browser/browser_main_mac.mm
index 2af66cb4cc4c8b1cde5ab55cdc40aea7e4026995..dafb62c8695cdf99d196e2431f0cdf98e82354a8 100644
--- a/chrome/browser/browser_main_mac.mm
+++ b/chrome/browser/browser_main_mac.mm
@@ -103,7 +103,8 @@ class BrowserMainPartsMac : public BrowserMainPartsPosix {
       std::string pref_locale;
       // TODO(markusheintz): Read preference pref::kApplicationLocale in order
       // to enforce the application locale.
-      ResourceBundle::InitSharedInstance(pref_locale);
+      std::string locale = ResourceBundle::InitSharedInstance(pref_locale);

[Peter Kasting, 2010/12/21 18:35:58]

Is this going to do the right thing?  We've never set |pref_locale|.  It seems
like we should, like we do on other platforms?

[glotov, 2010/12/21 20:33:34]

Yes, looks confusing, I rewrote it.
As I mentioned above, InitSharedInstance() will choose the default locale then.

+      CHECK(!locale.empty()) << "Locale could not be found for " << pref_locale;

[Peter Kasting, 2010/12/21 18:35:58]

Nit: Same nit

[glotov, 2010/12/21 20:33:34]

Done.

 
       FilePath resources_pack_path;
       PathService::Get(chrome::FILE_RESOURCES_PACK, &resources_pack_path);