chrome/browser/chromeos/login/wizard_controller.cc - Issue 5939002: Error handling added

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/wizard_controller.cc

Issue 5939002: Error handling added (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: InitSharedResource() and ReloadSharedResource() return code is checked Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/login/wizard_controller.cc

diff --git a/chrome/browser/chromeos/login/wizard_controller.cc b/chrome/browser/chromeos/login/wizard_controller.cc

index 50aa4b2b33545fb7644083d12b828514a38de4bb..13a876075521f4e0e3da3437a610dab4bd6028f5 100644

--- a/chrome/browser/chromeos/login/wizard_controller.cc

+++ b/chrome/browser/chromeos/login/wizard_controller.cc

@@ -1007,7 +1007,8 @@ void ShowLoginWizard(const std::string& first_screen_name,

locale = controller->GetCustomization()->initial_locale();

VLOG(1) << "Initial locale: " << locale;

if (!locale.empty()) {

- ResourceBundle::ReloadSharedInstance(locale);

+ CHECK(ResourceBundle::ReloadSharedInstance(locale) == locale)

Peter Kasting 2010/12/20 17:18:48 Never do real work inside a CHECK or DCHECK.

glotov 2010/12/21 13:19:08 Done.

+ << "Locale could not be found for " << locale;

}