chrome/browser/browser_main_mac.mm - Issue 5939002: Error handling added

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browser_main_mac.mm

Issue 5939002: Error handling added (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: InitSharedResource() and ReloadSharedResource() return code is checked Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/browser_main_mac.mm

diff --git a/chrome/browser/browser_main_mac.mm b/chrome/browser/browser_main_mac.mm

index 2af66cb4cc4c8b1cde5ab55cdc40aea7e4026995..8f526450f276ee3c0e2a1788c5aa85eab6cc3113 100644

--- a/chrome/browser/browser_main_mac.mm

+++ b/chrome/browser/browser_main_mac.mm

@@ -103,7 +103,8 @@ class BrowserMainPartsMac : public BrowserMainPartsPosix {

std::string pref_locale;

// TODO(markusheintz): Read preference pref::kApplicationLocale in order

// to enforce the application locale.

- ResourceBundle::InitSharedInstance(pref_locale);

+ CHECK(ResourceBundle::InitSharedInstance(pref_locale) == pref_locale)

Peter Kasting 2010/12/20 17:18:48 Never do real work inside a CHECK or DCHECK.

glotov 2010/12/21 13:19:08 Done.

+ << "Locale could not be found for " << pref_locale;

FilePath resources_pack_path;

PathService::Get(chrome::FILE_RESOURCES_PACK, &resources_pack_path);