DOMUI: Implement new-style password manager.

chrome/browser/resources/shared/js/cr/ui/list_item.js

Index: chrome/browser/resources/shared/js/cr/ui/list_item.js
diff --git a/chrome/browser/resources/shared/js/cr/ui/list_item.js b/chrome/browser/resources/shared/js/cr/ui/list_item.js
index 283216f9b2bea2e217d9d83f64683ae00585f060..4674bbbdf377ea03e5a4b56523763f55bf38b47c 100644
--- a/chrome/browser/resources/shared/js/cr/ui/list_item.js
+++ b/chrome/browser/resources/shared/js/cr/ui/list_item.js
@@ -30,7 +30,13 @@ cr.define('cr.ui', function() {
      * Called when an element is decorated as a list item.
      */
     decorate: function() {
-    }
+    },
+
+    /**
+     * Called when the selection state of this element changes.
+     */
+    selectionChanged: function() {

[arv (Not doing code reviews), 2010/12/17 20:07:34]

I think a better way is to change the current selected setter to call this. That
unfortunately means that the macro can no longer be used but at least it
guarantees that we always call selectionChanged when selected changes instead of
relying on the caller to take care of it.

get selected() {
  return this.hasAttribute('selected');
},

set selected(selected) {
  selected = Boolean(selected);
  var oldSelected = this.selected;
  if (oldSelected == selected)
    return;
  if (selected)
    this.setAttribute('selected', '');
  else
    this.removeAttribute('selected');
  cr.dispatchPropertyChange(this, 'selected', selected, oldSelected);
  this.selectionChanged();
}

[James Hawkins, 2010/12/17 21:32:40]

Ok, I think I've made the change like you've suggested.  Question: why do you
cast selected to Boolean?  Is this a best practice to ensure that we're dealing
w/ a Boolean?

+    },
   };
 
   /**