Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7121)

Unified Diff: chrome/browser/resources/shared/js/cr/ui/list.js

Issue 5935003: DOMUI: Implement new-style password manager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fixes. Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/shared/js/cr/ui/list.js
diff --git a/chrome/browser/resources/shared/js/cr/ui/list.js b/chrome/browser/resources/shared/js/cr/ui/list.js
index 749d0ea88aeacd46b48d26010c851e140bdc5f98..85fc7124e03cf9a4275660c8002cce528b5ee1cd 100644
--- a/chrome/browser/resources/shared/js/cr/ui/list.js
+++ b/chrome/browser/resources/shared/js/cr/ui/list.js
@@ -346,8 +346,10 @@ cr.define('cr.ui', function() {
handleOnChange_: function(ce) {
ce.changes.forEach(function(change) {
var listItem = this.getListItemByIndex(change.index);
- if (listItem)
+ if (listItem && listItem.selected != change.selected) {
listItem.selected = change.selected;
+ listItem.selectionChanged();
arv (Not doing code reviews) 2010/12/17 20:07:34 You could just have made the selected setter virtu
James Hawkins 2010/12/17 21:32:40 Done.
+ }
}, this);
cr.dispatchSimpleEvent(this, 'change');
@@ -583,7 +585,7 @@ cr.define('cr.ui', function() {
},
/**
- * Redraws a single item
+ * Redraws a single item.
* @param {number} index The row index to redraw.
*/
redrawItem: function(index) {
@@ -591,7 +593,7 @@ cr.define('cr.ui', function() {
delete this.cachedItems_[index];
this.redraw();
}
- }
+ },
};
cr.defineProperty(List, 'disabled', cr.PropertyKind.BOOL_ATTR);

Powered by Google App Engine
This is Rietveld 408576698