DOMUI: Implement new-style password manager.

chrome/browser/resources/shared/js/cr/ui/list_item.js

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('cr.ui', function() {
 
   /**
    * Creates a new list item element.
    * @param {string} opt_label The text label for the item.
    * @constructor
@@ skipping 12 matching lines @@
       return this.textContent;
     },
     set label(label) {
       this.textContent = label;
     },
 
     /**
      * Called when an element is decorated as a list item.
      */
     decorate: function() {
-    }
+    },
+
+    /**
+     * Called when the selection state of this element changes.
+     */
+    selectionChanged: function() {

[arv (Not doing code reviews), 2010/12/17 20:07:34]

I think a better way is to change the current selected setter to call this. That
unfortunately means that the macro can no longer be used but at least it
guarantees that we always call selectionChanged when selected changes instead of
relying on the caller to take care of it.

get selected() {
  return this.hasAttribute('selected');
},

set selected(selected) {
  selected = Boolean(selected);
  var oldSelected = this.selected;
  if (oldSelected == selected)
    return;
  if (selected)
    this.setAttribute('selected', '');
  else
    this.removeAttribute('selected');
  cr.dispatchPropertyChange(this, 'selected', selected, oldSelected);
  this.selectionChanged();
}

[James Hawkins, 2010/12/17 21:32:40]

Ok, I think I've made the change like you've suggested.  Question: why do you
cast selected to Boolean?  Is this a best practice to ensure that we're dealing
w/ a Boolean?

+    },
   };
 
   /**
    * Whether the item is selected. Setting this does not update the underlying
    * selection model. This is only used for display purpose.
    * @type {boolean}
    */
   cr.defineProperty(ListItem, 'selected', cr.PropertyKind.BOOL_ATTR);
 
   /**
    * Whether the item is the lead in a selection. Setting this does not update
    * the underlying selection model. This is only used for display purpose.
    * @type {boolean}
    */
   cr.defineProperty(ListItem, 'lead', cr.PropertyKind.BOOL_ATTR);
 
   return {
     ListItem: ListItem
   };
 });