DOMUI: Implement new-style password manager.

chrome/browser/resources/shared/js/cr/ui/list.js

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // require: listselectionmodel.js
 
 /**
  * @fileoverview This implements a list control.
  */
 
@@ skipping 328 matching lines @@
 
     /**
      * Callback from the selection model. We dispatch {@code change} events
      * when the selection changes.
      * @param {!cr.Event} e Event with change info.
      * @private
      */
     handleOnChange_: function(ce) {
       ce.changes.forEach(function(change) {
         var listItem = this.getListItemByIndex(change.index);
-        if (listItem)
+        if (listItem && listItem.selected != change.selected) {
           listItem.selected = change.selected;
+          listItem.selectionChanged();

[arv (Not doing code reviews), 2010/12/17 20:07:34]

You could just have made the selected setter virtual.

[James Hawkins, 2010/12/17 21:32:40]

Done.

+        }
       }, this);
 
       cr.dispatchSimpleEvent(this, 'change');
     },
 
     /**
      * Handles a change of the lead item from the selection model.
      * @property {Event} pe The property change event.
      * @private
      */
@@ skipping 215 matching lines @@
       if (listItem) {
         var list = this;
         window.setTimeout(function() {
           if (listItem.parentNode == list)
             list.itemHeight_ = measureItem(list, listItem);
         });
       }
     },
 
     /**
-     * Redraws a single item
+     * Redraws a single item.
      * @param {number} index The row index to redraw.
      */
     redrawItem: function(index) {
       if (index >= this.firstIndex_ && index < this.lastIndex_) {
         delete this.cachedItems_[index];
         this.redraw();
       }
-    }
+    },
   };
 
   cr.defineProperty(List, 'disabled', cr.PropertyKind.BOOL_ATTR);
 
   return {
     List: List
   }
 });