DOMUI: Implement new-style password manager.

chrome/browser/resources/options/password_manager.js

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
-
-  var OptionsPage = options.OptionsPage;
+  const OptionsPage = options.OptionsPage;
+  const ArrayDataModel = cr.ui.ArrayDataModel;
+  const ListSingleSelectionModel = cr.ui.ListSingleSelectionModel;
 
   /////////////////////////////////////////////////////////////////////////////
   // PasswordManager class:
 
   /**
    * Encapsulated handling of password and exceptions page.
    * @constructor
    */
   function PasswordManager() {
     this.activeNavTab = null;
     OptionsPage.call(this,
                      'passwordManager',
-                     templateData.savedPasswordsTitle,
-                     'passwordManager');
+                     templateData.passwordsTitle,
+                     'password-manager');
   }
 
   cr.addSingletonGetter(PasswordManager);
 
   PasswordManager.prototype = {
     __proto__: OptionsPage.prototype,
 
+    savedPasswordsList_: null,

[stuartmorgan, 2010/12/17 00:40:21]

Should these be documented? I've been documenting all member variables in JS.

[James Hawkins, 2010/12/17 02:33:57]

Done.

+    passwordExceptionsList_: null,
+
     initializePage: function() {
       OptionsPage.prototype.initializePage.call(this);
 
-      options.passwordManager.PasswordsListArea.decorate($('passwordsArea'));
-      options.passwordManager.PasswordExceptionsListArea.decorate(
-          $('passwordExceptionsArea'));
+      this.createSavedPasswordsList_();
+      this.createPasswordExceptionsList_();
 
-      $('password-exceptions-nav-tab').onclick = function() {
-        OptionsPage.showTab($('password-exceptions-nav-tab'));
-        passwordExceptionsList.redraw();
-      }
+      chrome.send('updatePasswordLists');
+    },
+
+    createSavedPasswordsList_: function() {

[stuartmorgan, 2010/12/17 00:40:21]

Needs documentation

+      this.savedPasswordsList_ = $('saved-passwords-list');
+      options.passwordManager.PasswordsList.decorate(this.savedPasswordsList_);
+      this.savedPasswordsList_.selectionModel = new ListSingleSelectionModel;
+      this.savedPasswordsList_.autoExpands = true;
+    },
+
+    createPasswordExceptionsList_: function() {
+      this.passwordExceptionsList_ = $('password-exceptions-list');
+      options.passwordManager.PasswordExceptionsList.decorate(
+          this.passwordExceptionsList_);
+      this.passwordExceptionsList_.selectionModel =
+          new ListSingleSelectionModel;
+      this.passwordExceptionsList_.autoExpands = true;
     },
 
     setSavedPasswordsList_: function(entries) {

[stuartmorgan, 2010/12/17 00:40:21]

Ditto

[James Hawkins, 2010/12/17 02:33:57]

Done.

-      savedPasswordsList.clear();
-      for (var i = 0; i < entries.length; i++) {
-        savedPasswordsList.addEntry(entries[i]);
-      }
+      this.savedPasswordsList_.dataModel = new ArrayDataModel(entries);
     },
 
     setPasswordExceptionsList_: function(entries) {

[stuartmorgan, 2010/12/17 00:40:21]

Ditto

[James Hawkins, 2010/12/17 02:33:57]

Done.

-      passwordExceptionsList.clear();
-      for (var i = 0; i < entries.length; i++) {
-        passwordExceptionsList.addEntry(entries[i]);
-      }
+      this.passwordExceptionsList_.dataModel = new ArrayDataModel(entries);
     },
-
-  };
-
-  PasswordManager.load = function() {
-    chrome.send('loadLists');
   };
 
   /**
    * Call to remove a saved password.
    * @param rowIndex indicating the row to remove.
    */
   PasswordManager.removeSavedPassword = function(rowIndex) {
       chrome.send('removeSavedPassword', [String(rowIndex)]);
   };
 
   /**
    * Call to remove a password exception.
    * @param rowIndex indicating the row to remove.
    */
   PasswordManager.removePasswordException = function(rowIndex) {
       chrome.send('removePasswordException', [String(rowIndex)]);
   };
 
-
   /**
    * Call to remove all saved passwords.
    * @param tab contentType of the tab currently on.
    */
   PasswordManager.removeAllPasswords = function() {
     chrome.send('removeAllSavedPasswords');
   };
 
   /**
    * Call to remove all saved passwords.
    * @param tab contentType of the tab currently on.
    */
   PasswordManager.removeAllPasswordExceptions = function() {
     chrome.send('removeAllPasswordExceptions');
   };
 
-  PasswordManager.showSelectedPassword = function(index) {
-    chrome.send('showSelectedPassword', [String(index)]);
-  };
-
   PasswordManager.setSavedPasswordsList = function(entries) {
     PasswordManager.getInstance().setSavedPasswordsList_(entries);
   };
 
   PasswordManager.setPasswordExceptionsList = function(entries) {
     PasswordManager.getInstance().setPasswordExceptionsList_(entries);
   };
 
-  PasswordManager.selectedPasswordCallback = function(password) {
-    passwordsArea.displayReturnedPassword(password);
-  };
-
   // Export
   return {
     PasswordManager: PasswordManager
   };
 
 });