GetScriptLineNumber was changed. ...

GetScriptLineNumber was changed. 
Now it is using binary search instead of linear.

[loislo1, 2010-02-15 17:33:55]

GetScriptLineNumber was changed. 
Now it is using binary search algorithm.

[Søren Thygesen Gjesse, 2010-02-16 10:23:00]

LGTM

http://codereview.chromium.org/593108/diff/4/6
File src/handles.cc (right):

http://codereview.chromium.org/593108/diff/4/6#newcode491
src/handles.cc:491: while (int half = (right - left) / 2)
Please add {}'s for the while and if.

http://codereview.chromium.org/593108/diff/4/5
File test/cctest/test-compiler.cc (right):

http://codereview.chromium.org/593108/diff/4/5#newcode353
test/cctest/test-compiler.cc:353: buffer[buffer_size - 1] = 0;
0 -> '\0'

http://codereview.chromium.org/593108/diff/4/5#newcode356
test/cctest/test-compiler.cc:356: if (i)
(i) -> (i > 0)

http://codereview.chromium.org/593108/diff/4/5#newcode363
test/cctest/test-compiler.cc:363: CHECK_EQ(i, f->GetScriptLineNumber());
Maybe extend the test by adding a number of \n's after the function as well.

[loislo1, 2010-02-16 10:53:35]

Done.

I've removed PerfGetScriptLineNumber because it was need just for comparision
old implementation against new one.

http://codereview.chromium.org/593108/diff/4/6
File src/handles.cc (right):

http://codereview.chromium.org/593108/diff/4/6#newcode491
src/handles.cc:491: while (int half = (right - left) / 2)
On 2010/02/16 10:23:00, Søren Gjesse wrote:
> Please add {}'s for the while and if.

Done.

http://codereview.chromium.org/593108/diff/4/5
File test/cctest/test-compiler.cc (right):

http://codereview.chromium.org/593108/diff/4/5#newcode353
test/cctest/test-compiler.cc:353: buffer[buffer_size - 1] = 0;
On 2010/02/16 10:23:00, Søren Gjesse wrote:
> 0 -> '\0'

Done.

http://codereview.chromium.org/593108/diff/4/5#newcode356
test/cctest/test-compiler.cc:356: if (i)
On 2010/02/16 10:23:00, Søren Gjesse wrote:
> (i) -> (i > 0)

Done.

http://codereview.chromium.org/593108/diff/4/5#newcode363
test/cctest/test-compiler.cc:363: CHECK_EQ(i, f->GetScriptLineNumber());
On 2010/02/16 10:23:00, Søren Gjesse wrote:
> Maybe extend the test by adding a number of \n's after the function as well.

In this test the buffer initially filled with '\n' symbol and the test really
does CHECK for each position of function f inside the buffer.

[loislo1, 2010-02-16 12:56:10]

Regression at EquivalenceOfLoggingAndTraversal was fixed.