Issue 593087: make combine_libs.py not bail out when run under the system provided python u...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 593087: make combine_libs.py not bail out when run under the system provided python u... (Closed)

Created:
10 years, 10 months ago by slightlyoff

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, amit

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

make combine_libs.py not bail out when run under the system provided python under Cygwin. BUG=35342 TEST=in cygwin do: %> devenv /build Debug chrome.sln Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38950

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome_frame/combine_libs.py	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

Snazzulous! http://codereview.chromium.org/593087/diff/1001/1002 File chrome_frame/combine_libs.py (right): http://codereview.chromium.org/593087/diff/1001/1002#newcode1 chrome_frame/combine_libs.py:1: # Copyright (c) 2009 The Chromium Authors. All ...

10 years, 10 months ago (2010-02-12 21:28:51 UTC) #2

slightlyoff

10 years, 10 months ago (2010-02-12 21:38:52 UTC) #3

On 2010/02/12 21:28:51, Peter Kasting wrote:
> Snazzulous!
> 
> http://codereview.chromium.org/593087/diff/1001/1002
> File chrome_frame/combine_libs.py (right):
> 
> http://codereview.chromium.org/593087/diff/1001/1002#newcode1
> chrome_frame/combine_libs.py:1: # Copyright (c) 2009 The Chromium Authors. All
> rights reserved.
> Nit: 2010

Fixed.

Expand Messages | Collapse Messages