Issue 593080: Fix CallIC stub for CallInterceptor on ARM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 593080: Fix CallIC stub for CallInterceptor on ARM (Closed)

Created:
10 years, 10 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry, antonm

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix CallIC stub for CallInterceptor on ARM Committed: http://code.google.com/p/v8/source/detail?r=3848

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/arm/stub-cache-arm.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM. If you can make a tiny .cc benchmark that could be added to the ...

10 years, 10 months ago (2010-02-12 15:53:02 UTC) #2

William Hesse

10 years, 10 months ago (2010-02-12 15:59:48 UTC) #3

Verified that without the fix test-api/InterceptorCallIC cycles back and forth
between megamorphic and monomorphic, and with the fix it stays monomorphic.

Expand Messages | Collapse Messages