Issue 593014: Making lint happy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 593014: Making lint happy. (Closed)

Created:
10 years, 10 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Making lint happy. Committed: http://code.google.com/p/v8/source/detail?r=3827

Patch Set 1 #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -10 lines)			Patch
M	samples/lineprocessor.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/d8-readline.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/cctest/test-debug.cc	View	4 chunks	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

antonm

Søren, may you have a look? My lint is somewhat more restrictive.

10 years, 10 months ago (2010-02-09 15:33:33 UTC) #1

Søren Thygesen Gjesse

LGTM How can it be that you are using a different cpplint?

10 years, 10 months ago (2010-02-10 08:22:29 UTC) #2

antonm

10 years, 10 months ago (2010-02-10 11:38:43 UTC) #3

I don't remember for sure, probably due to some previous projects.

I've got

zsh/3 758 % readlink -f $(which cpplint.py)           
/home/build/nonconf/google3/devtools/cpplint/cpplint.py

And some warnings I got seems to be google3-specific:

zsh/3 575 % ./tools/presubmit.py
/usr/local/google/homedirs/antonm/chromium/src/v8/src/d8-readline.cc:30:  Found
C system header after C++ system header. Should be: d8-readline.h, c system, c++
system, other.  [build/include_order] [4]
/usr/local/google/homedirs/antonm/chromium/src/v8/src/d8-readline.cc:31:  Found
C system header after C++ system header. Should be: d8-readline.h, c system, c++
system, other.  [build/include_order] [4]
Done processing
/usr/local/google/homedirs/antonm/chromium/src/v8/src/d8-readline.cc
/usr/local/google/homedirs/antonm/chromium/src/v8/samples/lineprocessor.cc:155: 
Consider using [safe_]strto32/64(...) instead of atoi(...) (deprecated). 
[runtime/deprecated_fn] [1]
Done processing
/usr/local/google/homedirs/antonm/chromium/src/v8/samples/lineprocessor.cc
/usr/local/google/homedirs/antonm/chromium/src/v8/test/cctest/test-debug.cc:3895:
 Consider using [safe_]strto32/64(...) instead of atoi(...) (deprecated). 
[runtime/deprecated_fn] [1]
/usr/local/google/homedirs/antonm/chromium/src/v8/test/cctest/test-debug.cc:3908:
 Consider using [safe_]strto32/64(...) instead of atoi(...) (deprecated). 
[runtime/deprecated_fn] [1]
/usr/local/google/homedirs/antonm/chromium/src/v8/test/cctest/test-debug.cc:3922:
 Consider using [safe_]strto32/64(...) instead of strtol(...) (deprecated). 
[runtime/deprecated_fn] [1]
Done processing
/usr/local/google/homedirs/antonm/chromium/src/v8/test/cctest/test-debug.cc
Total errors found: 6

May you tell me where your cpplint.py resides?

And thanks a lot for review.

On 2010/02/10 08:22:29, Søren Gjesse wrote:
> LGTM
> 
> How can it be that you are using a different cpplint?

Expand Messages | Collapse Messages