Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 5930003: DOMUI Settings: UTH: Fix the wrapping of the privacy explanation text. (Closed)

Created:
10 years ago by kmadhusu
Modified:
9 years, 7 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

DOMUI Settings: UTH: Fix the wrapping of the privacy explanation text. BUG=63835 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69557

Patch Set 1 #

Patch Set 2 : Moved generic message to generated_resources.grd file. #

Total comments: 8

Patch Set 3 : "Made code changes as per comments." #

Total comments: 4

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -10 lines) Patch
M chrome/app/chromium_strings.grd View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/options/advanced_options_handler.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/advanced_options.css View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/resources/options/advanced_options.html View 1 2 3 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kmadhusu
10 years ago (2010-12-16 01:46:21 UTC) #1
James Hawkins
http://codereview.chromium.org/5930003/diff/2001/chrome/app/chromium_strings.grd File chrome/app/chromium_strings.grd (right): http://codereview.chromium.org/5930003/diff/2001/chrome/app/chromium_strings.grd#newcode401 chrome/app/chromium_strings.grd:401: <!--TODO(kmadhusu): Remove/delete "IDS_OPTIONS_DISABLE_SERVICES" after DOMUI Settings is complete. It ...
10 years ago (2010-12-16 02:34:00 UTC) #2
kmadhusu
http://codereview.chromium.org/5930003/diff/2001/chrome/app/chromium_strings.grd File chrome/app/chromium_strings.grd (right): http://codereview.chromium.org/5930003/diff/2001/chrome/app/chromium_strings.grd#newcode401 chrome/app/chromium_strings.grd:401: <!--TODO(kmadhusu): Remove/delete "IDS_OPTIONS_DISABLE_SERVICES" after DOMUI Settings is complete. It ...
10 years ago (2010-12-16 17:41:37 UTC) #3
James Hawkins
http://codereview.chromium.org/5930003/diff/10001/chrome/browser/resources/options/advanced_options.css File chrome/browser/resources/options/advanced_options.css (right): http://codereview.chromium.org/5930003/diff/10001/chrome/browser/resources/options/advanced_options.css#newcode7 chrome/browser/resources/options/advanced_options.css:7: .disable-services { I'm not sure I like this class ...
10 years ago (2010-12-16 21:26:58 UTC) #4
kmadhusu
http://codereview.chromium.org/5930003/diff/10001/chrome/browser/resources/options/advanced_options.css File chrome/browser/resources/options/advanced_options.css (right): http://codereview.chromium.org/5930003/diff/10001/chrome/browser/resources/options/advanced_options.css#newcode7 chrome/browser/resources/options/advanced_options.css:7: .disable-services { On 2010/12/16 21:26:58, James Hawkins wrote: > ...
10 years ago (2010-12-16 22:08:58 UTC) #5
James Hawkins
10 years ago (2010-12-16 22:21:26 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698