Issue 5928005: Fixes to get ctest up and running again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5928005: Fixes to get ctest up and running again. (Closed)

Created:
10 years ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
dgarrett

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git@master

Visibility:
Public.

Description

Fixes to get ctest up and running again. We had a major issue because the latest dev channel release pre-dates the virtio change. Because of this, ctest was connecting to update that channel using virtio (which is unsupported for that). This change drops a file telling the vm lib to use e1000 as before. Also, fixed stateful change logic. Change-Id: I394a8cece71bdd0d55efa21ba5b6d24804432c6b BUG=chromium-os:10434 TEST=Ran it with ctest and cros_au_test_harness on images with/without the file. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=40fa0de

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -19 lines)			Patch
M	bin/cros_au_test_harness.py	View	1	10 chunks	+28 lines, -18 lines	0 comments	Download
M	bin/ctest.py	View	1 2 3	2 chunks	+8 lines, -0 lines	0 comments	Download
M	lib/cros_vm_lib.sh	View		1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dgarrett

LGTM. Is there some way to make eclipse more aggressive about cleaning up white space ...

10 years ago (2010-12-17 21:08:28 UTC) #1

sosa

10 years ago (2010-12-17 21:12:29 UTC) #2

If you go into window->preferences->pydev->editor->code style ...
there are a lot of options here (especially in code formatter).  You
could even select to auto format when saving ... though I usually just
explicitly use it (ctrl+shift+f)

-Sosa

On Fri, Dec 17, 2010 at 1:08 PM,  <dgarrett@chromium.org> wrote:
> LGTM.
>
> Is there some way to make eclipse more aggressive about cleaning up white
> space
> like this?
>
> http://codereview.chromium.org/5928005/
>

Expand Messages | Collapse Messages

Issue 5928005: Fixes to get ctest up and running again. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Nits #

Patch Set 3 : No image to live #

Patch Set 4 : no verbose #

Messages