Issue 5928001: Linux: Allow IO in ProcessMetrics::GetWorkingSetKBytes()....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5928001: Linux: Allow IO in ProcessMetrics::GetWorkingSetKBytes().... (Closed)

Created:
10 years ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin, evanm

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Linux: Allow IO in ProcessMetrics::GetWorkingSetKBytes(). BUG=61340 TEST=Opening up the task manager on Linux in debug mode does not assert. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69331

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -6 lines)			Patch
	M	base/process_util_linux.cc	View		2 chunks	+17 lines, -6 lines	0 comments	Download

Total messages: 2 (0 generated)

evanm

10 years ago (2010-12-15 21:46:00 UTC) #2

LGTM

It's too bad we have to keep adding these for proc.  I've been considering
making ReadFileToString check whether the path starts with /proc...