Issue 5927004: Another attempt at landing:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5927004: Another attempt at landing:... (Closed)

Created:
10 years ago by dmichael(do not use this one)

Modified:
9 years, 7 months ago

Reviewers:
neb

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Another attempt at landing: http://codereview.chromium.org/5730003/ Previously r69187 Check-in was almost clean, but checkdeps.py flagged it as having invalid includes (because the Clang plugins aren't meant to be built as part of Chrome). This adds the magic incantation (a DEPS file... who knew?) to make checkdeps.py ignore it. Tested by running checkdeps.py in my gclient before and after. BUG=61004, 62983 TEST=compile asserts and ppapi/tests/test_struct_sizes.c Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69483

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+754 lines, -0 lines)			Patch
A	ppapi/generate_ppapi_size_checks.py	View	1 chunk	+346 lines, -0 lines	0 comments	Download
A	ppapi/tests/DEPS	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A	ppapi/tests/clang/Makefile	View	1 chunk	+67 lines, -0 lines	0 comments	Download
A	ppapi/tests/clang/README	View	1 chunk	+32 lines, -0 lines	0 comments	Download
A	ppapi/tests/clang/find_affected_interfaces.cc	View	1 chunk	+154 lines, -0 lines	0 comments	Download
A	ppapi/tests/clang/print_names_and_sizes.cc	View	1 chunk	+150 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

neb

10 years ago (2010-12-16 23:16:17 UTC) #2

There's no need to open a new review for this, LGTM stands. And I think you can
use a closed review for a checkin.

Expand Messages | Collapse Messages