Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 5923001: Updated to latest sudo from portage. (Closed)

Created:
10 years ago by diandersAtChromium
Modified:
9 years, 6 months ago
CC:
chromium-os-reviews_chromium.org, msb+crosoverlay_chromium.org, adlr, anush
Visibility:
Public.

Description

Updated to latest sudo from portage. From portage checkout (git checkout cros/gentoo): HEAD is now at 99628ad... gentoo.org updates Wed Dec 8 09:01:01 MST 2010 update This change should be pushed after the fix to update_kernel: http://codereview.chromium.org/5859002/ This change should be pushed "at the same time" as the fix to image_to_live: http://codereview.chromium.org/5929001/ Hopefully, I didn't miss any other places that will break. --- Change-Id: If20d7c2659442d9d8d0883409357928a9d6df64b BUG=chromium-os:7072 TEST=Built and ran with this new sudo for a while w/ no problems. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=0cba3d4

Patch Set 1 #

Patch Set 2 : Deleted unnecessary files from portage. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1272 lines, -0 lines) Patch
A app-admin/sudo/ChangeLog View 1 chunk +1006 lines, -0 lines 0 comments Download
A app-admin/sudo/files/sudo-skeychallengeargs.diff View 1 chunk +15 lines, -0 lines 0 comments Download
A app-admin/sudo/metadata.xml View 1 chunk +11 lines, -0 lines 0 comments Download
A app-admin/sudo/sudo-1.7.4_p4.ebuild View 1 chunk +240 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
diandersAtChromium
I tried to push this fix many months ago when I was younger and stupider. ...
10 years ago (2010-12-15 21:53:14 UTC) #1
Daniel Kurtz
10 years ago (2010-12-15 22:09:10 UTC) #2
Do we still need 1.7.4_p3-r1.ebuild & files/sudo-CVE...patch?

Can you send a PSA, too, when you push... just in case :)

Otherwise, LGTM

On 2010/12/15 21:53:14, diandersAtChromium wrote:
> I tried to push this fix many months ago when I was younger and stupider. 
> Hopefully it works better this time.
> 
> 
> As a reminder:
> 
> - New sudo applies to both chroot and target and fixes some minor security
> issues.
> 
> 
> - New sudo fixes how parameters are passed with "sudo -i".  The old sudo had a
> bug that would cause it to strip off one level of quoting from parameters
passed
> to subcommands.  Some of our scripts rely on this sudo bug, so they'll need to
> be fixed as we find them (I tried to find as many as I could--see related
> issues).
> 
> 
> FYI:
> 
> old sudo: sudo -i -- echo "a   b  c" e f
> ==> a b c e f
> 
> old sudo: sudo -i -- 'echo "a   b  c" e f'
> ==> a   b  c e f
> 
> sudo 1.7.4_p4: sudo -i -- echo "a   b  c" e f
> ==> a   b  c e f
> 
> sudo 1.7.4_p4: sudo -i -- 'echo "a   b  c" e f'
> ==> -bash: echo "a   b  c" e f: command not found

Powered by Google App Engine
This is Rietveld 408576698