chrome/test/functional/test_utils.py - Issue 5921001: Make sure private data does not inadverently get printed out

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/functional/test_utils.py

Issue 5921001: Make sure private data does not inadverently get printed out (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: chrome/test/functional/test_utils.py

diff --git a/chrome/test/functional/test_utils.py b/chrome/test/functional/test_utils.py

index cdd3f0524f51d40c325f4bacf8d8c39f5e6229b7..978e488ff4c9bd32f7a472605127024f92f34052 100644

--- a/chrome/test/functional/test_utils.py

+++ b/chrome/test/functional/test_utils.py

@@ -87,7 +87,9 @@ def VerifyGoogleAccountCredsFilled(test, username, password, tab_index=0,

passwd_value = test.GetDOMValue('document.getElementById("Passwd").value',

windex, tab_index)

test.assertEqual(email_value, username)

- test.assertEqual(passwd_value, password)

+ # Not using assertEqual because if it fails it would end up dumping the

+ # password (which is supposed to be private)

+ test.assertTrue(passwd_value == password)

def ClearPasswords(test):

« no previous file with comments | « no previous file | no next file » | no next file with comments »