test/cxxflags/cxxflags.gyp - Issue 5917002: Changed the order of toolset and gyp CFLAGS, CXXFLAGS and LDFLAGS.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test/cxxflags/cxxflags.gyp

Issue 5917002: Changed the order of toolset and gyp CFLAGS, CXXFLAGS and LDFLAGS. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/

Patch Set: '' Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright (c) 2009 Google Inc. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 {

	6 'targets': [

	7 {

	8 'target_name': 'cxxflags',

	9 'type': 'executable',
	Evan Martin 2010/12/17 23:27:06 Should this include an opt flag setting? It seems Should this include an opt flag setting? It seems before we also obeyed CFLAGS from the environment; what your change is changing is making sure CFLAGS from the environment override CFLAGS from the gyp file. So I think you should put some flag in this file to verify that your environment setting is overriding it.
	10 'sources': [

	11 'cxxflags.cc',

	12 ],

	13 },

	14 ],

	15 }

OLD	NEW

« no previous file with comments | « test/cxxflags/cxxflags.cc ('k') | test/cxxflags/gyptest-cxxflags.py » ('j') | no next file with comments »